Veritula – Meta

  Dennis Hackethal commented on criticism #1986.

Bug: when cycling through ‘filtered’ revisions (meaning there are more revisions that don’t lead to the highlighted idea), the criticism badge can change count for the same revision.

#1986·Dennis HackethalOP revised 3 months ago

For all ideas, the total number of pending criticisms (if any) should always be shown, even if they are not all being rendered.

  Dennis Hackethal addressed criticism #1989.

That could mislead people into thinking a revision has no pending criticisms.

#1989·Dennis HackethalOP, 3 months ago

The instructions at the top of the page are clear that not all ideas are being rendered.

  Dennis Hackethal revised criticism #1988 and unmarked it as a criticism.

When cycling back to the revision, it should continue to display only the count of the shown criticisms.

When cycling back to the revision, it should continue to display only the count of the shown criticisms.

  Dennis Hackethal addressed criticism #1988.

When cycling back to the revision, it should continue to display only the count of the shown criticisms.

#1988·Dennis HackethalOP, 3 months ago

That could mislead people into thinking a revision has no pending criticisms.

  Dennis Hackethal addressed criticism #1986.

Bug: when cycling through ‘filtered’ revisions (meaning there are more revisions that don’t lead to the highlighted idea), the criticism badge can change count for the same revision.

#1986·Dennis HackethalOP revised 3 months ago

When cycling back to the revision, it should continue to display only the count of the shown criticisms.

  Dennis Hackethal revised criticism #1985.

Bug: when cycling through ‘filtered’ revisions (meaning there are more revisions that don’t lead to the highlighted idea), the criticism badge can change count for the same idea.

Bug: when cycling through ‘filtered’ revisions (meaning there are more revisions that don’t lead to the highlighted idea), the criticism badge can change count for the same revision.

  Dennis Hackethal submitted criticism #1985.

Bug: when cycling through ‘filtered’ revisions (meaning there are more revisions that don’t lead to the highlighted idea), the criticism badge can change count for the same idea.

  Dennis Hackethal addressed criticism #1956.

Bug: when clicking the link to the activity in #1953, the idea is replaced with “Content missing”.

#1956·Dennis HackethalOP, 3 months ago

Fixed as of 985d05a.

  Dennis Hackethal submitted criticism #1956.

Bug: when clicking the link to the activity in #1953, the idea is replaced with “Content missing”.

  Dennis Hackethal addressed criticism #1953.

https://veritula.com/activities/1808

Since the discussions starts with an idea, there should be a reply button.

#1953·Dennis HackethalOP, 3 months ago

Done as of bfe04e2.

  Dennis Hackethal submitted criticism #1953.

https://veritula.com/activities/1808

Since the discussions starts with an idea, there should be a reply button.

  Dennis Hackethal addressed criticism #1923.

Edwin says to either have hover effects for all clickable items or none of them. Buttons currently don’t have hover effects but links do.

I could remove hover effects from links. macOS links in System Settings don’t have a hover effect either. (They don’t even have a pointer cursor but IMO that’s going too far.)

#1923·Dennis HackethalOP revised 3 months ago

When there are two links next to each other, like when it says “Dennis Hackethal revised” in the activity feed, the user needs some way to see that they’re two links and not just one. Underline on hover shows them that.

  Dennis Hackethal addressed criticism #1930.

Add hover effects to schemed buttons so there’s consistency with the existing hover effects for links.

#1930·Dennis HackethalOP revised 3 months ago

Done as of ea37007.

  Dennis Hackethal revised criticism #1923. The revision addresses idea #1929.

Edwin says to either have hover effects for all clickable items or none of them. Buttons currently don’t have hover effects but links do.

I could remove hover effects from links. macOS links in System Settings don’t have a hover effect either. (They don’t even have a pointer cursor but IMO that’s going too far.)

Add hover effects to schemed buttons so there’s consistency with the existing hover effects for links.

  Dennis Hackethal addressed criticism #1923.

Edwin says to either have hover effects for all clickable items or none of them. Buttons currently don’t have hover effects but links do.

I could remove hover effects from links. macOS links in System Settings don’t have a hover effect either. (They don’t even have a pointer cursor but IMO that’s going too far.)

#1923·Dennis HackethalOP revised 3 months ago

I tried removing hover effects on links in dev and the user experience suffered as a result.

Especially for smaller links, like the hash links in idea headers, it’s nice getting that visual feedback that you are in fact hovering over the link and your click won’t miss it.

  Dennis Hackethal addressed criticism #1907.

Done as of b423e18.

#1907·Dennis HackethalOP, 3 months ago

Reverted as of f8ed700.

  Dennis Hackethal revised criticism #1920. The revision addresses idea #1921.

@edwin-de-wit says buttons should have a hover effect.

Edwin says to either have hover effects for all clickable items or none of them. Buttons currently don’t have hover effects but links do.

I could remove hover effects from links. macOS links in System Settings don’t have a hover effect either. (They don’t even have a pointer cursor but IMO that’s going too far.)

  Dennis Hackethal addressed criticism #1921.

I went back and forth on this. Native macOS buttons don’t have a hover effect and the human-interface guys at Apple are world class. I’m inclined to defer to their expertise. They know things I don’t.

#1921·Dennis HackethalOP, 3 months ago

Edwin says to be consistent. Either have hover effects for all clickable items or none of them.

I could remove hover effects from links. macOS links in System Settings don’t have a hover effect either. (They don’t even have a pointer cursor but IMO that’s going too far.)

  Dennis Hackethal addressed criticism #1920.

@edwin-de-wit says buttons should have a hover effect.

#1920·Dennis HackethalOP, 3 months ago

I went back and forth on this. Native macOS buttons don’t have a hover effect and the human-interface guys at Apple are world class. I’m inclined to defer to their expertise. They know things I don’t.

  Dennis Hackethal submitted criticism #1920.

@edwin-de-wit says buttons should have a hover effect.

  Dennis Hackethal addressed criticism #1889.

Should I be showing the comment form by default on ideas#show?

To avoid scrolling past content, I could remove the autofocus on the textarea unless a certain query parameter is given.

#1889·Dennis HackethalOP revised 3 months ago

Having implemented this, a problem has surfaced: when linking to an old version of an idea, the alert “You’re about to comment on an old version of this idea. Are you sure …” shows. That’s jarring if you didn’t want to comment but merely look at the idea.

  Dennis Hackethal addressed criticism #1889.

Should I be showing the comment form by default on ideas#show?

To avoid scrolling past content, I could remove the autofocus on the textarea unless a certain query parameter is given.

#1889·Dennis HackethalOP revised 3 months ago

Done as of b423e18.

  Dennis Hackethal revised criticism #1891. The revision addresses idea #1904.

I could turn the ‘Revise…’ button into an icon button that lives next to the collapse icon button. It could just have a pencil for an icon.

That way, the button wouldn’t need to be hidden anymore.

As of acb14e3, the revision button is an icon button that lives next to the collapse icon button.

Therefore, the button doesn’t need to be hidden anymore.

  Dennis Hackethal addressed criticism #1891.

I could turn the ‘Revise…’ button into an icon button that lives next to the collapse icon button. It could just have a pencil for an icon.

That way, the button wouldn’t need to be hidden anymore.

#1891·Dennis HackethalOP, 3 months ago

Done as of acb14e3.

  Dennis Hackethal addressed criticism #1892.

That would mean the revise button would be at the top of the idea. But presumably, people would typically want to revise an idea after they finish reading it. Meaning after they reach the bottom.

#1892·Dennis HackethalOP, 3 months ago

It could go both ways. Someone may have already read an idea and just wants to revise it, in which case having to scroll to the bottom is cumbersome.