Activity

Dennis Hackethal addressed criticism #3951.

Done as of cc1ab95.

Ruby example:

1
2
3
4
5
6
7
8
9
10
11
ruby
def criticized? idea
  pending_criticisms(idea).any?
end

def pending_criticisms idea
  criticisms(idea).filter { |c| pending_criticisms(c).none? }
end

def criticisms idea
  children(idea).filter(&:criticism?)
end

JS example (h/t ChatGPT):

1
2
3
4
5
6
7
8
9
10
11
javascript
function criticized(idea) {
  return pendingCriticisms(idea).length > 0;
}

function pendingCriticisms(idea) {
  return criticisms(idea).filter(c => pendingCriticisms(c).length === 0);
}

function criticisms(idea) {
  return children(idea).filter(c => c.isCriticism);
}

#3951·Dennis HackethalOP, 18 days ago

There’s still an issue on ideas#show. When an idea has nothing but a code block, there’s too much of a margin at the bottom, between the block and the border of the highlight.

18 days ago·‘Veritula – Meta’